kgabryje commented on a change in pull request #14823:
URL: https://github.com/apache/superset/pull/14823#discussion_r641543437
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -197,7 +206,9 @@ export default function ActivityTable({
label: t('Created'),
onClick: () => {
setActiveChild('Created');
- setInLocalStorage('activity', { activity: 'Created' });
+ setInLocalStorage(HOMEPAGE_ACTIVITY_FILTER, {
+ activity: SetTabType.CREATED,
Review comment:
Do we need to save an object to the local storage? Can't we just
`setInLocalStorage(HOMEPAGE_ACTIVITY_FILTER, SetTabType.CREATED)`? Same applies
to other uses
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
