eschutho commented on a change in pull request #14830:
URL: https://github.com/apache/superset/pull/14830#discussion_r645113640
##########
File path: superset-frontend/src/SqlLab/components/TableElement.jsx
##########
@@ -156,26 +137,28 @@ class TableElement extends React.PureComponent {
{keyLink}
<IconTooltip
className={
- `fa fa-sort-${!this.state.sortColumns ? 'alpha' : 'numeric'}-asc `
+
+ `fa fa-sort-${!sortColumns ? 'alpha' : 'numeric'}-asc ` +
Review comment:
small nit, and this is from earlier code, but for readability:
`fa fa-sort-${sortColumns ? 'numeric' : 'alpha' }-asc ` +
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
