AAfghahi commented on pull request #14830:
URL: https://github.com/apache/superset/pull/14830#issuecomment-852408801
> @corbinrobb can you fix these issues to allow CI to pass
>
> ```
>
/home/runner/work/superset/superset/superset-frontend/src/SqlLab/components/TableElement.jsx
> 35:1 error `src/components/Icons` import should occur before import
of `../../components/CopyToClipboard` import/order
> 70:9 error 'popSelectStar' is assigned a value but never used
no-unused-vars
> 192:30 error Unexpected block statement surrounding arrow body; move
the returned value immediately after the `=>` arrow-body-style
> 264:36 error Unexpected block statement surrounding arrow body; move
the returned value immediately after the `=>` arrow-body-style
> 280:20 error Curly braces are unnecessary here
react/jsx-curly-brace-presence
> 292:7 error Value must be omitted for boolean attributes
react/jsx-boolean-value
> ```
So I actually think popSelectStar is depreciated. Might be worth setting up
a test env to check to make sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
