nytai commented on a change in pull request #14652:
URL: https://github.com/apache/superset/pull/14652#discussion_r644400222
##########
File path: Makefile
##########
@@ -38,6 +38,22 @@ superset:
# Load some data to play with
superset load-examples
+update:
Review comment:
Ah, I didn't know, though somehow I'm not surprised. I found this issue,
apparently it's quite a controversial subject
https://github.com/npm/npm/issues/17979... I guess it's too much to ask for
your package manager to behave predictably 🤦
##########
File path: Makefile
##########
@@ -38,6 +38,22 @@ superset:
# Load some data to play with
superset load-examples
+update:
Review comment:
Though, reading through the issue it appears this behavior has been
patched in recent versions of `npm@^5.4.2` and it behaves as I have described
above
https://github.com/npm/npm/issues/17979#issuecomment-332701215
##########
File path: Makefile
##########
@@ -38,6 +38,22 @@ superset:
# Load some data to play with
superset load-examples
+update:
Review comment:
I've seen the same but I think that's due to slight differences in npm
version. I haven't seen actual package version changes in the lockfile, it
seems like it's usually formatting changes or updates to the integrity sha. I
think it would be valuable to lock down the [version of node & npm we are all
using](https://github.com/apache/superset/blob/765e9dd93259fbf2ded9117017704e3fd5cd86d8/superset-frontend/package.json#L58)
to a specific version and update these scripts to ensure the correct version
of node/npm is being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
