[GitHub] [superset] zhaoyongjie opened a new pull request #15014: fix: consistent dataset list

[GitBox]

zhaoyongjie opened a new pull request #15014:
URL: https://github.com/apache/superset/pull/15014


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   closes: https://github.com/apache/superset/issues/14262
   
   Currently, between the `Dataset list view` and `change dataset modal` 
datasets order is inconsistent. The `change dataset modal` can not display all 
datasets. 
   
   This PR make
   1. `Dataset list view` and `change dataset modal` datasets order is 
consistent
   2. make server pagination in `change dataset modal`
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### Before
   <img width="1471" alt="image" 
src="https://user-images.githubusercontent.com/2016594/120994394-044c8b80-c7b7-11eb-9558-e19d7d8d425a.png";>
   
   #### After
   Consistent dataset list between `dataset list` and `Change dataset modal`
   <img width="1473" alt="image" 
src="https://user-images.githubusercontent.com/2016594/120994651-44ac0980-c7b7-11eb-9f20-8450d362d9d7.png";>
   
   
   
https://user-images.githubusercontent.com/2016594/120997286-a66d7300-c7b9-11eb-8210-04bec81a4db9.mp4
   
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://github.com/apache/superset/issues/14262
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org