AAfghahi commented on a change in pull request #15095:
URL: https://github.com/apache/superset/pull/15095#discussion_r649380437
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -370,7 +370,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
className="preferred-item"
onClick={() => setDatabaseModel(database.engine)}
buttonText={database.name}
- icon={dbImages[database.engine]}
+ icon={dbImages && dbImages[database.engine]}
Review comment:
I think this might be better as a const in the component that you then
call.
You might also want to check this with no image because I am pretty sure
icon is a required class on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
