hughhhh commented on a change in pull request #15095:
URL: https://github.com/apache/superset/pull/15095#discussion_r649428550
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -370,7 +370,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
className="preferred-item"
onClick={() => setDatabaseModel(database.engine)}
buttonText={database.name}
- icon={dbImages[database.engine]}
+ icon={dbImages && dbImages[database.engine]}
Review comment:
I want to keep the component functional, and i add a condition for the
icon inside the compenent. Basically this will default to the default icon if
icon isnt set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
