[GitHub] [superset] kgabryje opened a new pull request #15146: fix(native-filters): Don't send unnecessary PUT request on dashboard render

[GitBox]

kgabryje opened a new pull request #15146:
URL: https://github.com/apache/superset/pull/15146


   ### SUMMARY
   When dashboard first renders, we calculate tabs and charts in scope of each 
native filter. Before, we used to send a PUT request with the results, which 
also modified dashboard's metadata. This PR fixes that behaviour by saving the 
results only in redux, without sending them to the backend.
   This PR is related to an issue raised by @graceguo-supercat in comments 
https://github.com/apache/superset/pull/14933#discussion_r650331375 and 
https://github.com/apache/superset/pull/14933#issuecomment-860168672. The 
problem with setting properties `show_native_filters` and 
`native_filter_configuration` was not caused directly by PR 
https://github.com/apache/superset/pull/14933, but the problem was elevated by 
that PR because of sending unnecessary PUT request. That issue will be handled 
in a separate PR by @villebro.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Notice that in "AFTER" screenshot there's no request to `/dashboard` 
endpoint which modifies metadata.
   Before:
   
![image](https://user-images.githubusercontent.com/15073128/121876082-70744580-cd09-11eb-87f8-278a831739e0.png)
   
   After:
   
![image](https://user-images.githubusercontent.com/15073128/121875923-4753b500-cd09-11eb-8652-732cd5701365.png)
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: 
https://github.com/apache/superset/pull/14933#discussion_r650331375
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC: @villebro @graceguo-supercat 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org