villebro commented on a change in pull request #15146:
URL: https://github.com/apache/superset/pull/15146#discussion_r650867699
##########
File path: superset-frontend/src/dashboard/actions/nativeFilters.ts
##########
@@ -49,6 +49,11 @@ export interface SetFilterConfigFail {
type: typeof SET_FILTER_CONFIG_FAIL;
filterConfig: FilterConfiguration;
}
+export const SET_FILTER_SCOPES = 'SET_FILTER_SCOPES';
+export interface SetFilterScopes {
+ type: typeof SET_FILTER_SCOPES;
+ filterConfig: FilterConfiguration;
+}
Review comment:
To avoid potential confusion with the scopes defined in metadata, it
could be nice to call this (and related variables/functions) something more
explicit, like `SET_IN_SCOPE_STATUS_OF_FILTERS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
