[GitHub] [superset] AAfghahi opened a new pull request #15151: feat: adding server-side validation and unmasked password on create

Mon, 14 Jun 2021 09:44:41 -0700 


AAfghahi opened a new pull request #15151:
URL: https://github.com/apache/superset/pull/15151


   ### SUMMARY
   This is part of polishing up the db-connection-ui. We are creating 
server-side validation so that port cannot be string, also 'unmasking' password 
on the creation of a db. 
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Creating a database
   <img width="571" alt="Screen Shot 2021-06-14 at 12 43 17 PM" 
src="https://user-images.githubusercontent.com/48933336/121928421-217cdf00-cd0e-11eb-85ae-8c0555d67ddc.png";>
   
   Editing a database:
   <img width="533" alt="Screen Shot 2021-06-14 at 12 43 25 PM" 
src="https://user-images.githubusercontent.com/48933336/121928466-2d68a100-cd0e-11eb-8a93-22967d81e343.png";>
   
   ### TESTING INSTRUCTIONS
   Go to Data
   go to databases
   add a database 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to