AAfghahi commented on a change in pull request #15151:
URL: https://github.com/apache/superset/pull/15151#discussion_r651120746
##########
File path: superset/db_engine_specs/base.py
##########
@@ -1438,7 +1438,7 @@ def validate_parameters(
return errors
port = parameters.get("port", None)
- if not port:
+ if not port or type(port) is str:
Review comment:
currently, using the form, you can't pass in a string into the
db-connection-modal because frontend side it is `type=number` so it only
accepts numbers.
I think the validation was if someone was using the api, and not the form.
Would the marshmellow validation pick that up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
