benjreinhart edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861735262
@villebro yeah I think from an interface design PoV, it's definitely cleaner to have consistent behavior / response structure. So I think you're right to question this change. The reasoning thus far has been performance related. We've noticed in our testing that there are times when the celery queue gets congested quickly and latency increases. A number of those tasks are to run queries in the background. A subset of those tasks will end up returning the cached result. For the subset that is cached, this change will help take some load off the celery queues and also reduce the chances that users are stuck waiting for celery queues to process a task before they can see their chart render. @robdiciuccio may have some additional reasoning. That being said, after typing that out, it does feel like the best solution is to get celery into a more predictable state with separate queues and resource allocation. I know @robdiciuccio has been working hard on that, so maybe there's an update there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
