robdiciuccio edited a comment on pull request #15157: URL: https://github.com/apache/superset/pull/15157#issuecomment-861887944
We had this debate early on, whether pre-cached data should be returned synchronously. There are pros and cons here, as @benjreinhart pointed out. We're realizing potential performance gains while making the API slightly more complex. That said, the responses from the API endpoints use different HTTP status codes for different use cases (200 for cached data, 202 for async job metadata). Personally, I feel it's acceptable for an API endpoint to have different status code responses for different use cases, but this quickly gets pretty subjective and philosophical. The problem we're trying to solve for with this change is avoiding chart/dashboard rendering delays due to (unnecessary) async job workflows for pre-cached data. Running Celery at scale without delays is \*cough\* difficult, and we're optimizing for user experience. Happy to continue the discussion and get additional viewpoints. I believe @ktmud and @etr2460 had comments on this in the initial implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
