villebro opened a new pull request #15257:
URL: https://github.com/apache/superset/pull/15257


   ### SUMMARY
   Currently the default value picker requires two clicks on the checkbox to 
disable the default value. This fixes the bug and makes the code slightly more 
readable.
   
   ### AFTER
   
https://user-images.githubusercontent.com/33317356/122564634-434bce00-d04e-11eb-8c62-8c2d6b8fa1e9.mp4
   
   ### BEFORE
   
https://user-images.githubusercontent.com/33317356/122564682-4e9ef980-d04e-11eb-8e5d-de402b90c112.mp4
   
   ### TESTING INSTRUCTIONS
   Local testing
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to