michael-s-molina commented on pull request #15257: URL: https://github.com/apache/superset/pull/15257#issuecomment-864400864
When the user checks "Filter has default value", shouldn't the default value be required similar to "Filter is hierarchical" or "Pre-filter available values"? It's really strange if the user says that the filter has a default value but doesn't fill the value. Also, the spacing between the "DEFAULT VALUE" label and the input is greater than before. If you look at "Filter is hierarchical" you will see what's the correct spacing. https://user-images.githubusercontent.com/70410625/122642383-95d5ca80-d0e0-11eb-825e-5539426e2910.mov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
