zhaoyongjie commented on pull request #15279: URL: https://github.com/apache/superset/pull/15279#issuecomment-866702014
> Some comments. Also, I'm unable to get the offsets to work. When I try to do a 1 year offset, I get the following results (notice that the offset label is correct, but the data is the same as the original query): > ![image](https://user-images.githubusercontent.com/33317356/123075236-b83d5000-d420-11eb-94ea-04cb61449886.png) > > The same parameters on the NVD3 Line chart: > ![image](https://user-images.githubusercontent.com/33317356/123075342-d1de9780-d420-11eb-99f2-f35cfe09a7b4.png) This is because the original offset is always negative. (offset backward, if the current is 2016-2017, `the 1 year offset ago`, is 2017-2018) For the new design, I would like to put `ago/later` into the time interval. This allows the user to know which direction to do offset. for this question, the dataset may be have not before `1 year ago` data in the new time-series viz. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org