stephenLYZ opened a new pull request #15384:
URL: https://github.com/apache/superset/pull/15384


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Currently, the zIndex of dashboard's content is `1`, which is lower than 
dashboard's title panel(`2`). We should set that to higher in chart maximize 
mode.  In order to achieve this requirement, I put the full-size state in redux 
so that the parent element can get this.
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   ### before
   
   
https://user-images.githubusercontent.com/11830681/123392547-c2ea1780-d5cf-11eb-8a47-93ac1155b313.mov
   
   
   ### after
   
   
https://user-images.githubusercontent.com/11830681/123392569-c7163500-d5cf-11eb-9550-b28dc1f3b55b.mov
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://github.com/apache/superset/issues/15348
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to