stephenLYZ commented on a change in pull request #15384:
URL: https://github.com/apache/superset/pull/15384#discussion_r661396972
##########
File path:
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx
##########
@@ -89,10 +89,12 @@ const StyledHeader = styled.div`
z-index: 2;
`;
-const StyledContent = styled.div`
+const StyledContent = styled.div<{
+ fullSizeChartId: number | null;
+}>`
grid-column: 2;
grid-row: 2;
- z-index: 1;
+ z-index: ${({ fullSizeChartId }) => (fullSizeChartId ? 1000 : 1)};
Review comment:
I agreed. There seems to be no place to manage all z-index values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
