[GitHub] [superset] andrewbastian opened a new pull request #15431: fix: Error Icon not showing up on errored input fieds on validation

[GitBox]

andrewbastian opened a new pull request #15431:
URL: https://github.com/apache/superset/pull/15431


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   CSS `mask` for Icon SVG was triggering a get request to 
`localhost:.../Images/Icons/error.svg` and returning a 404 error. This was 
fixed by importing the SVG at the top of the file and adding it onto the `mask` 
inside the CSS variable. Some alignment was also needed on this CSS variable to 
get it centered in the field.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ##BEFORE:
   
   <img width="1440" alt="Screen Shot 2021-06-28 at 11 13 56 AM" 
src="https://user-images.githubusercontent.com/50464395/123684346-31162080-d802-11eb-93ff-ec422c06e918.png";>
   
   ##AFTER:
   
   <img width="1440" alt="Screen Shot 2021-06-28 at 11 02 50 AM" 
src="https://user-images.githubusercontent.com/50464395/123684428-4c812b80-d802-11eb-8109-68f0986ca691.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   Adding a test to the `DatabaseModal` to check for the SVG icon after 
`fireEvent`
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org