lyndsiWilliams commented on a change in pull request #15431:
URL: https://github.com/apache/superset/pull/15431#discussion_r660078398
##########
File path: superset-frontend/src/components/Form/LabeledErrorBoundInput.tsx
##########
@@ -49,18 +49,17 @@ const alertIconStyles = (theme: SupersetTheme, hasError:
boolean) => css`
${hasError &&
`.ant-form-item-control-input-content {
position: relative;
-
&:after {
content: ' ';
display: inline-block;
background: ${theme.colors.error.base};
- mask: url('/images/icons/error.svg');
+ mask: url(${errorIcon});
mask-size: cover;
width: ${theme.gridUnit * 4}px;
height: ${theme.gridUnit * 4}px;
position: absolute;
- right: 7px;
- top: 15px;
+ right: 2%;
Review comment:
Could you change `right` and `top` to have static values with `px`
instead of `%`? The field size shouldn't be changing so a static value should
be fine here. Could you also change the value to use `theme.gridUnit`? Each
gridUnit is 4, so if you wanted a value of 16px you'd do `${theme.gridUnit *
4}px`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
