simcha90 commented on a change in pull request #15454:
URL: https://github.com/apache/superset/pull/15454#discussion_r661979346
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -352,8 +344,8 @@ const FiltersConfigForm = (
// @ts-ignore
const hasDataset = !!nativeFilterItems[formFilter?.filterType]?.value
?.datasourceCount;
- const hasColumn =
- hasDataset && !FILTERS_WITHOUT_COLUMN.includes(formFilter?.filterType);
+ const hasColumn = hasDataset;
Review comment:
I think we don't need anymore `hasColumn`, you can remove it and use in
every place `hasDataset`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
