simcha90 commented on a change in pull request #15454:
URL: https://github.com/apache/superset/pull/15454#discussion_r661979663
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -484,7 +476,6 @@ const FiltersConfigForm = (
(defaultDatasetSelectOptions.length === 1
? defaultDatasetSelectOptions[0].value
: undefined);
- const initColumn = filterToEdit?.targets[0]?.column?.name;
const newFormData = getFormData({
datasetId,
groupby: hasColumn ? formFilter?.column : undefined,
Review comment:
also here I think we don't need this condition, we can just leave:
```
groupby: formFilter?.column,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
