[GitHub] [superset] pkdotson opened a new pull request #15593: refactor: icon to icons for sqllab

Thu, 08 Jul 2021 11:22:54 -0700 


pkdotson opened a new pull request #15593:
URL: https://github.com/apache/superset/pull/15593


   ### SUMMARY
   This pr migrates the icons in sqllab editor to the new icons component.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   before
   <img width="466" alt="Screen Shot 2021-07-08 at 6 29 50 AM" 
src="https://user-images.githubusercontent.com/17326228/124971897-9aeeb100-dfde-11eb-9a21-bd7b8f4509ad.png";>
   <img width="131" alt="1 SAVE AS" 
src="https://user-images.githubusercontent.com/17326228/124971990-ae018100-dfde-11eb-8a7d-83d90b6a5a1f.png";>
   <img width="128" alt="COPY LINK" 
src="https://user-images.githubusercontent.com/17326228/124972028-bbb70680-dfde-11eb-9646-19644ec094ab.png";>
   
   
   after
   <img width="375" alt="Screen Shot 2021-07-08 at 7 16 05 AM" 
src="https://user-images.githubusercontent.com/17326228/124971927-a0e49200-dfde-11eb-8985-1db477d7a4e2.png";>
    <img width="118" alt="SAVE AS" 
src="https://user-images.githubusercontent.com/17326228/124972007-b3f76200-dfde-11eb-975c-ccf25450fb9a.png";>
   <img width="123" alt="2 COPY LINK" 
src="https://user-images.githubusercontent.com/17326228/124972051-c2de1480-dfde-11eb-8bdd-41846d295169.png";>
   
   
   
   ### TESTING INSTRUCTIONS
   Go to sql editor to check out icons
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to