suddjian commented on a change in pull request #15593:
URL: https://github.com/apache/superset/pull/15593#discussion_r667245861
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -39,6 +39,16 @@ interface ShareSqlLabQueryPropTypes {
addDangerToast: (msg: string) => void;
}
+const SytledIcon = styled(Icons.Link)`
Review comment:
typo: StyledIcon
```suggestion
const SyledIcon = styled(Icons.Link)`
```
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -39,6 +39,16 @@ interface ShareSqlLabQueryPropTypes {
addDangerToast: (msg: string) => void;
}
+const SytledIcon = styled(Icons.Link)`
Review comment:
typo: StyledIcon
```suggestion
const StyledIcon = styled(Icons.Link)`
```
##########
File path: superset-frontend/src/SqlLab/components/ShareSqlLabQuery.tsx
##########
@@ -86,14 +96,12 @@ function ShareSqlLabQuery({
: t('Save the query to enable this feature');
return (
<Button buttonSize="small" tooltip={tooltip} disabled={!canShare}>
- <Icon
- name="link"
+ <SytledIcon
Review comment:
```suggestion
<StyledIcon
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
