[GitHub] [superset] michael-s-molina commented on pull request #15480: chore: Improves the Select component UI/UX - iteration 4

[GitBox]

michael-s-molina commented on pull request #15480:
URL: https://github.com/apache/superset/pull/15480#issuecomment-882587231


   > Hey @michael-s-molina please find the results of my manual testing efforts 
below:
   > 
   > I have noticed a problem with the creation of new options. It is now 
allowing for the creation of existing options, which would then make 
unselecting any of the duplicated options impossible. It gets stuck.
   > 
   > <img alt="Screen Shot 2021-07-19 at 15 25 47" width="1123" 
src="https://user-images.githubusercontent.com/60598000/126167097-c5cf70be-b1c0-45e0-b9df-5165edc76b4d.png";>
   > 
   > I don't see my newly created option "test" in the dropdown in multiple mode
   > 
   > <img alt="Screen Shot 2021-07-19 at 15 35 09" width="931" 
src="https://user-images.githubusercontent.com/60598000/126168220-6a8f2a6a-ae60-4afe-9af1-f04ee07bb018.png";>
   > 
   > I don't see my newly created option in the dropdown in single mode. I 
think this used to work consistently with the single mode ON and 
allowNewOptions OFF, where the selected option is highlighted at top of the 
options list
   > 
   > <img alt="Screen Shot 2021-07-19 at 15 41 50" width="920" 
src="https://user-images.githubusercontent.com/60598000/126169363-ea55db1e-cb09-4a16-b10f-8b805a57c53f.png";>
   > 
   > I am not sure if this is related to this PR but I am unable to create 
hierarchical filters. The child filter never appears anywhere. Only the parent 
is showing up. When I go back to editing, the hierarchical option is always 
unchecked as if it wasn't saved.
   > 
   > <img alt="Screen Shot 2021-07-19 at 15 39 38" width="1272" 
src="https://user-images.githubusercontent.com/60598000/126168868-10c72d63-74d2-4479-bd64-aba8cece077e.png";>
   > 
   > After adding a new filter, the previously selected options of the existing 
filters are not selected anymore. This may be because I haven't clicked 
"Apply", however, as a user I would expect that my filters remain filled as I 
add or delete other filters, even before applying (I am fine if this needs to 
be discussed outside of the scope of this PR)
   > 
   > <img alt="Screen Shot 2021-07-19 at 15 29 27" width="1058" 
src="https://user-images.githubusercontent.com/60598000/126167491-c893a91e-1582-46aa-b6ea-96d21ee1b8ba.png";>
   
   Thanks for the throughout testing. None of the issues are related to this 
PR. The first 3 are related to the Select component and will be fixed in 
separate PRs. The last 2 are isolated issues. Will open separate PRs also. So 
the plan is to open these separate PRs and then rebase this PR on top of the 
fixes. So let's leave this open for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org