michael-s-molina commented on pull request #15480: URL: https://github.com/apache/superset/pull/15480#issuecomment-883355500
@geido @rusackas @junlincc > I have noticed a problem with the creation of new options. It is now allowing for the creation of existing options, which would then make unselecting any of the duplicated options impossible. It gets stuck. > > I don't see my newly created option "test" in the dropdown in multiple mode > > I don't see my newly created option in the dropdown in single mode. I think this used to work consistently with the single mode ON and allowNewOptions OFF, where the selected option is highlighted at top of the options list > After investigation, I discovered that these were not bugs in the new `Select` component but problems in the `SelectFilterPlugin` component. `SelectFilterPlugin` contained duplicated logic already present in the `Select` component. I removed the duplicated logic. > I am not sure if this is related to this PR but I am unable to create hierarchical filters. The child filter never appears anywhere. Only the parent is showing up. When I go back to editing, the hierarchical option is always unchecked as if it wasn't saved. > This was in fact related to this PR. Fixed. > After adding a new filter, the previously selected options of the existing filters are not selected anymore. This may be because I haven't clicked "Apply", however, as a user I would expect that my filters remain filled as I add or delete other filters, even before applying (I am fine if this needs to be discussed outside of the scope of this PR) > This one is by design, until now we only keep the values if the user clicks on "Apply". We can change this behavior if the product team agrees but if that's the case we need to open another low priority issue. @rusackas @geido I also applied all your suggestions. @geido Thanks for testing the features. I updated the environment and requested your review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
