john-bodley opened a new pull request #15823: URL: https://github.com/apache/superset/pull/15823
### SUMMARY A follow up to https://github.com/apache/superset/pull/15757#discussion_r674140292, per the Mypy [documentation](https://mypy.readthedocs.io/en/stable/getting_started.html#more-function-signatures), > *args and **kwargs arguments can be annotated like so: > > ```python > def stars(*args: int, **kwargs: float) -> None: > # 'args' has type 'Tuple[int, ...]' (a tuple of ints) > # 'kwargs' has type 'Dict[str, float]' (a dict of strs to floats) > for arg in args: > print(arg) > for key, value in kwargs: > print(key, value) > ``` though `kwargs` is a `Dict[str, ...]` the typing of `**kwargs` is actually the value typ. ### TESTING INSTRUCTIONS CI. Found all violations by running `git grep "**kwargs: Dict"`. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
