john-bodley commented on a change in pull request #15823:
URL: https://github.com/apache/superset/pull/15823#discussion_r674254543
##########
File path: superset/charts/api.py
##########
@@ -683,7 +683,7 @@ def data_from_cache(self, cache_key: str) -> Response:
f".cache_screenshot",
log_to_statsd=False,
)
- def cache_screenshot(self, pk: int, **kwargs: Dict[str, bool]) ->
WerkzeugResponse:
+ def cache_screenshot(self, pk: int, **kwargs: Any) -> WerkzeugResponse:
Review comment:
The `bool` is incorrect given the logic below,
```
rison_dict = kwargs["rison"]
window_size = rison_dict.get("window_size")
```
i.e., clearly the type of the `kwargs` value (`rison_dict`) is of type
`Dict[str, ...]` rather than `bool`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
