betodealmeida opened a new pull request #15846:
URL: https://github.com/apache/superset/pull/15846


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   https://github.com/apache/superset/pull/15830/ modified the `_get_csv_data` 
functionality in the reports executor to use a new chart API introduced in 
https://github.com/apache/superset/pull/15827/. The problem is the new API can 
only be called for charts that were saved with their `query_context`, a change 
that was introduced in https://github.com/apache/superset/pull/15824.
   
   Pre-existing charts have `query_context` set to null, so we can't use the 
new API with them. As a workaround, @hughhhh implemented logic to save 
`query_context` when a chart that doesn't have it saved is loaded (WIP). This 
PR leverages that work by taking a screenshot of the chart using Selenium 
whenever we need to call the API but `query_context`  is null.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   N/A
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   WIP
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to