betodealmeida commented on a change in pull request #15846:
URL: https://github.com/apache/superset/pull/15846#discussion_r677746110
##########
File path: superset/reports/commands/execute.py
##########
@@ -207,11 +207,18 @@ def _get_screenshot(self) -> bytes:
return image_data
def _get_csv_data(self) -> bytes:
- if self._report_schedule.chart:
- url = self._get_url(csv=True)
- auth_cookies =
machine_auth_provider_factory.instance.get_auth_cookies(
- self._get_user()
- )
+ url = self._get_url(csv=True)
+ auth_cookies = machine_auth_provider_factory.instance.get_auth_cookies(
+ self._get_user()
+ )
+
+ # To load CSV data from the endpoint the chart must have been saved
+ # with its query context. For charts without saved query context we
+ # get a screenshot to force the chart to produce and save the query
+ # context.
+ if self._report_schedule.chart.query_context is None:
+ self._get_screenshot()
Review comment:
Good point, I'll add some error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
