AAfghahi commented on a change in pull request #15852:
URL: https://github.com/apache/superset/pull/15852#discussion_r675844563
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -156,7 +157,7 @@ class Header extends React.PureComponent {
this.hidePropertiesModal = this.hidePropertiesModal.bind(this);
this.showReportModal = this.showReportModal.bind(this);
this.hideReportModal = this.hideReportModal.bind(this);
- this.handleReportClick = this.handleReportClick.bind(this);
+ this.reportModal = this.reportModal.bind(this);
Review comment:
yeah I wasn't happy with this and couldn't place my finger on it, I had
spaced on using render, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
