eschutho commented on a change in pull request #15852:
URL: https://github.com/apache/superset/pull/15852#discussion_r676868655
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -379,11 +380,27 @@ class Header extends React.PureComponent {
this.setState({ showingReportModal: false });
}
- handleReportClick() {
+ renderReportModal() {
const attachedReportExists = this.props.report?.count > 0;
- if (!attachedReportExists) {
- this.showReportModal();
- }
+ return attachedReportExists ? (
+ <HeaderReportActionsDropdown
+ showReportModal={this.showReportModal}
+ hideReportModal={this.hideReportModal}
+ report={this.props.report.result}
+ />
+ ) : (
+ <>
Review comment:
nit for another iteration, but I don't think you need these extra
brackets since you only have one child
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
