kgabryje opened a new pull request #16090:
URL: https://github.com/apache/superset/pull/16090


   ### SUMMARY
   Allows defining `canDropValue` function in `mapStateToProps` of controls in 
control panel (in superset-ui).
   That will allow us not only to use generic `canDrop` functions for columns 
or adhoc metrics, but also more advanced ones - like `can drop column "gender" 
in "Series" control only if "Breakdown" control doesn't already have this 
column added`.
   
   It's a prerequisite for fixing issue 
https://github.com/apache/superset/issues/16071
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   No changes
   
   ### TESTING INSTRUCTIONS
   0. Enable dnd
   1. Verify that everything works as before
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC: @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to