kgabryje commented on pull request #16090: URL: https://github.com/apache/superset/pull/16090#issuecomment-895047605
@michael-s-molina We can only check control's own value in `canDrop`. The point was to 1) allow checking values of other controls, so that for example user can add a value to control1 only if that value hasn't been added to control2. That can be done in `mapStateToProps` function in chart's control panel in superset-ui, and that's were `canDropValue` is supposed to be defined if needed. And 2) this allows us to define `canDrop` rules specific to a given control, which doesn't apply to all `DndColumnControl` type controls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
