michael-s-molina commented on a change in pull request #16102:
URL: https://github.com/apache/superset/pull/16102#discussion_r685080085
##########
File path: superset-frontend/src/views/CRUD/welcome/Welcome.tsx
##########
@@ -96,6 +104,12 @@ const WelcomeContainer = styled.div`
div.ant-collapse-item:last-child .ant-collapse-header {
padding-bottom: ${({ theme }) => theme.gridUnit * 9}px;
}
+ .loading-cards {
+ margin-top: 16px;
Review comment:
```suggestion
margin-top: ${({ theme }) => theme.gridUnit * 4}px;
```
##########
File path: superset-frontend/src/views/CRUD/welcome/Welcome.tsx
##########
@@ -118,6 +132,14 @@ const WelcomeNav = styled.div`
}
`;
+export const LoadingCards = ({ cover }: LoadingProps) => (
+ <CardContainer showThumbnails={cover} className="loading-cards">
+ {[...new Array(8)].map(() => (
Review comment:
We could export `8` to a constant with a meaningful name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
