rusackas commented on pull request #16102: URL: https://github.com/apache/superset/pull/16102#issuecomment-895520934
Looking good! And approving! I made one more comment about a const, and also noticed this little issue, which could be tackled in a separate PR or this one (since the issue is ALMOST fixed by this PR): As you can barely see in this GIF, when changing tabs, the loading state looks great, but goes higher up very briefly because the row containing the tabs very briefly disappears from the layout when switching tabs. If that disappearance can be solved, so it just changes without "blinking" we should be in awesome shape! Again, maybe this is a follow-up PR and not a blocker for this one. CC @junlincc for any ticketing/prioritization awareness.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
