[GitHub] [superset] villebro commented on a change in pull request #16263: chore(pylint): Reenable import-outside-toplevel check

Mon, 16 Aug 2021 00:46:56 -0700 


villebro commented on a change in pull request #16263:
URL: https://github.com/apache/superset/pull/16263#discussion_r689307160



##########
File path: superset/reports/dao.py
##########
@@ -138,7 +139,6 @@ def create(cls, properties: Dict[str, Any], commit: bool = 
True) -> Model:
         create a report schedule and nested recipients
         :raises: DAOCreateFailedError
         """
-        import json

Review comment:
       I think cases like these are motivation enough for enabling this check - 
I assume this was unintentional, and was probably a misclick in an IDE (this 
context menu from PyCharm when clicking Option+Return): 
   
![image](https://user-images.githubusercontent.com/33317356/129528629-d505abaa-87ad-4ea4-9acc-ff05fa819d4f.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to