john-bodley commented on a change in pull request #16263:
URL: https://github.com/apache/superset/pull/16263#discussion_r689665867
##########
File path: superset/reports/dao.py
##########
@@ -138,7 +139,6 @@ def create(cls, properties: Dict[str, Any], commit: bool =
True) -> Model:
create a report schedule and nested recipients
:raises: DAOCreateFailedError
"""
- import json
Review comment:
@villebro agreed, though as pointed out in the description this check
highlights the cyclical dependencies which unnecessarily exist and we should
strive to eradicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
