geido opened a new pull request #16273: URL: https://github.com/apache/superset/pull/16273
### SUMMARY This PR: - Makes the Omnibar appear on the Dashboards' list with _cmd + k_ or _ctrl + k_ - Clears up the search when the Omnibar is closed - Disables autocomplete - Closes the Omnibar when clicking outside https://user-images.githubusercontent.com/60598000/129581716-efc4100b-2156-4db6-bac6-1a9e68d25c2c.mp4 ### TESTING INSTRUCTIONS 1. Open the dashboards' list 2. Press _cmd + k_ or _ctrl + k_ on your keyboard 3. Search for dashboards and move with the arrows through the results 4. Close the Omnibar by pressing ESC 5. Reopen the modal and observe that the latest search input and options are gone ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #16198 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
