craig-rueda commented on a change in pull request #16135:
URL: https://github.com/apache/superset/pull/16135#discussion_r690543739
##########
File path: superset/initialization/__init__.py
##########
@@ -563,6 +563,8 @@ def init_app(self) -> None:
# Configuration of feature_flags must be done first to allow init
features
# conditionally
self.configure_feature_flags()
+ if feature_flag_manager.is_feature_enabled("SECRET_KEYS_ROTATIONS"):
Review comment:
Just always call `self.configure_secret_keys()`, which performs a no-op
by default. Then, downstreams can implement their own logic by extending
`Supersetinitializer`
##########
File path: setup.py
##########
@@ -88,6 +88,7 @@ def get_git_sha() -> str:
"humanize",
"itsdangerous>=1.0.0, <2.0.0", #
https://github.com/apache/superset/pull/14627
"isodate",
+ "keys-management>=0.1.5, <0.2.0",
Review comment:
This still has a hard requirement on the `keys-management` lib. Instead
of introducing this dependency, downstream projects can drag this in on their
own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
