craig-rueda commented on a change in pull request #16135:
URL: https://github.com/apache/superset/pull/16135#discussion_r694104034
##########
File path: setup.py
##########
@@ -88,6 +88,7 @@ def get_git_sha() -> str:
"humanize",
"itsdangerous>=1.0.0, <2.0.0", #
https://github.com/apache/superset/pull/14627
"isodate",
+ "keys-management>=0.1.5, <0.2.0",
Review comment:
I think that rather than dragging in this dependency, we should
introduce a set of hooks, similar to this PR: #16284, which can then be plugged
into by folks downstream to use whatever libs they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
