geido opened a new pull request #16394: URL: https://github.com/apache/superset/pull/16394
### SUMMARY This PR introduces four new options to the Modal component `resizable`: It makes the Modal resizable using re-resizable `resizableConfig`: It accepts a re-resizable configuration object `draggable`: It makes the Modal draggable using react-draggable `resizableConfig`: It accepts a react-draggable configuration object The `resizable` and `draggable` are completely independent of each other, they can be used in combination or not used at all. _Note: When `resizable` or/and `draggable` are used, the Modal mask will be disabled._ _Note: When `resizable` and `draggable` are **not** used, the original Modal node will be returned. This is to minimize the impact of these changes on existing Modals. ### VIEW QUERY MODAL Both resizable` and `draggable` options have been enabled for the "View Query" Modal. The Modal has been slightly enhanced in order for the `SyntaxHighlighter` Component to take the full height. ### BEFORE <img width="1680" alt="Screen Shot 2021-08-22 at 23 16 11" src="https://user-images.githubusercontent.com/60598000/130369026-e0bb113b-266d-4b62-91e4-dfaaecca146b.png";> ### AFTER https://user-images.githubusercontent.com/60598000/130369005-45e1e8a5-a90f-4d6c-9814-48918b49ffdd.mp4 ### TESTING INSTRUCTIONS 1. Open Explore 2. Click on "View Query" 3. Hover the title and drag the Modal in the window 4. Hover and drag the right, right bottom, and bottom corners to resize the modal ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #16205 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/60598000/130369026-e0bb113b-266d-4b62-91e4-dfaaecca146b.png"](https://user-images.githubusercontent.com/60598000/130369026-e0bb113b-266d-4b62-91e4-dfaaecca146b.png"){kind=link}