villebro commented on a change in pull request #16394:
URL: https://github.com/apache/superset/pull/16394#discussion_r694751528
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -129,6 +150,42 @@ export const StyledModal =
styled(BaseModal)<StyledModalProps>`
&.no-content-padding .ant-modal-body {
padding: 0;
}
+
+ ${({ draggable }) =>
+ draggable &&
+ `
+ .ant-modal-header {
+ .draggable-trigger {
+ cursor: move;
+ width: 100%;
+ }
+ }
+ `};
Review comment:
It would be nice if the draggable trigger covered the whole header, not
just the title:
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -46,6 +53,10 @@ export interface ModalProps {
wrapProps?: object;
height?: string;
closable?: boolean;
+ resizable?: boolean;
+ resizableConfig?: ResizableProps;
+ draggable?: boolean;
+ draggableConfig?: DraggableProps;
Review comment:
It feels slightly redundant to have four props for essentially two
features. Would it be possible to squeeze the `resizable` into `ResizableProps`
as an `enabled` prop which is assumed to default to `false`? Same for
`draggable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
