victornoel commented on a change in pull request #6541: [SIP-14] remove
dependency on yarn in favor of npm
URL:
https://github.com/apache/incubator-superset/pull/6541#discussion_r242126456
##########
File path: .travis.yml
##########
@@ -54,11 +51,10 @@ jobs:
- language: node_js
node_js: 8.9
cache:
- yarn: true
before_install:
- cd superset/assets
install:
- - yarn install --frozen-lockfile
+ - npm install
Review comment:
I think the proper command would be `npm ci` (see
https://docs.npmjs.com/cli/ci.html) which is the equivalent of yarn's
`frozen-lockfile`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
