victornoel commented on a change in pull request #6541: [SIP-14] remove dependency on yarn in favor of npm URL: https://github.com/apache/incubator-superset/pull/6541#discussion_r242127026
########## File path: superset/assets/js_build.sh ########## @@ -3,8 +3,7 @@ set -e cd "$(dirname "$0")" npm --version node --version -npm install -g yarn -yarn +npm install Review comment: I'm not sure about this one… depends on when `js_build.sh` is used :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
