villebro commented on a change in pull request #16394:
URL: https://github.com/apache/superset/pull/16394#discussion_r694889331
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -46,6 +53,10 @@ export interface ModalProps {
wrapProps?: object;
height?: string;
closable?: boolean;
+ resizable?: boolean;
+ resizableConfig?: ResizableProps;
+ draggable?: boolean;
+ draggableConfig?: DraggableProps;
Review comment:
Yes, that works just fine. The reason I pointed this out is this prop
structure looked "unexpected" (for the lack of a better word), but I assumed
there was a good reason for it. I completely agree; let's get this merged soon
and do many small iterative improvements later rather than one big PR now 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
