geido opened a new pull request #16446:
URL: https://github.com/apache/superset/pull/16446


   ### SUMMARY
   It replaces the react-select Select component with the Antdesign one in the 
SaveModal component.
   
   Note: There is a small UI glitch in the Select component. When a new option 
is being created the "No data" panel is showing up while it should not. This 
will need to be fixed on the Select component itself. CC @michael-s-molina 
   
   ### BEFORE
   
   
https://user-images.githubusercontent.com/60598000/130793778-66310951-f4fe-4e8c-b398-a4c02621ff68.mp4
   
   ### AFTER
   
   
https://user-images.githubusercontent.com/60598000/130793897-9f91cfcc-9724-4563-9cdd-450e48468731.mp4
   
   ### TESTING INSTRUCTIONS
   1. Open a Chart in Explore
   2. Click on Save
   3. Save the Chart in an existing Dashboard or create a new one
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to