michael-s-molina commented on a change in pull request #16446:
URL: https://github.com/apache/superset/pull/16446#discussion_r696572221
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -393,6 +394,10 @@ const Select = ({
setSelectOptions(newOptions);
setSelectValue(searchValue);
}
+
+ if (onChange) {
Review comment:
Yes, you're right. But we also shouldn't fire the event when a user
searches for a value that already exists because the value won't be selected
automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
