ofekisr opened a new pull request #16449:
URL: https://github.com/apache/superset/pull/16449


   SUMMARY
   The sql_json view code in superset core view without any "clean code" 
standard and it does not adopt any software development principle.
   This is the second PR in the sequence of future PRs (previous PR) try to 
solve it by refactoring the code.
   The PR focus of encapsulate and separate the getting and checking existing 
query concern into ad hoc methods.
   
   TESTING INSTRUCTIONS
   there are no logic changes so it implies on the current tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to