villebro commented on a change in pull request #16449:
URL: https://github.com/apache/superset/pull/16449#discussion_r696261154
##########
File path: superset/views/core.py
##########
@@ -2725,9 +2714,9 @@ def sql_json_exec( # pylint:
disable=too-many-statements,too-many-locals
mydb.db_engine_spec.get_limit_from_sql(rendered_query),
execution_context.limit,
]
- if limits[0] is None or limits[0] > limits[1]:
+ if limits[0] is None or limits[0] > limits[1]: # type: ignore
query.limiting_factor = LimitingFactor.DROPDOWN
- elif limits[1] > limits[0]:
+ elif limits[1] > limits[0]: # type: ignore
Review comment:
I'm curious, what were these type errors? The code appears to be
unchanged for these variables, so it's weird that mypy is raising errors now..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
